skills/agent-sort/SKILL.md (3)

219-233: Consider validating hardcoded item lists against actual ECC structure.

The hardcoded list of always-DAILY items (lines 223-231) creates coupling to specific ECC content. If these items are renamed or removed in future ECC versions, the skill could fail silently or produce incorrect results.

Consider adding validation:

• Check that listed items exist in ECC before assuming they're DAILY
• Generate warnings for missing expected items
• Or derive the list dynamically based on ECC metadata rather than hardcoding

This would make the skill more resilient to ECC structure changes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@skills/agent-sort/SKILL.md` around lines 219 - 233, The hardcoded
"always-DAILY" lists (the Agents/Skills/Commands/Contexts block containing
entries like planner, architect, code-reviewer, coding-standards, tdd-workflow,
learn, checkpoint, dev, review) must be validated against the ECC at runtime:
update the code that consumes this SKILL.md list to query the ECC metadata for
each named Agent/Skill/Command/Context, log a warning for any missing items, and
fallback to deriving the DAILY set dynamically from ECC tags/metadata if many
expected items are absent; ensure the validation and warning logic references
the same identifiers ("Agents", "Skills", "Commands", "Contexts" groups and the
individual names) so mismatches are detected rather than silently assumed.

---

137-149: Consider adding concrete copy command examples.

The installation patterns (lines 139-149) use convention notation like "Agents → .claude/skills/{name}/SKILL.md" which may be clear to AI agents but could benefit from concrete examples for human users.

Example: Add command templates

### Copy DAILY items
For each DAILY agent:
```bash
AGENT_NAME="agent-name"  # extracted from agent-name.md
mkdir -p ".claude/skills/${AGENT_NAME}"
cp "${ECC_PATH}/agents/${AGENT_NAME}.md" ".claude/skills/${AGENT_NAME}/SKILL.md"

For each DAILY skill:

SKILL_NAME="skill-name"  # extracted from skills/skill-name/
cp -r "${ECC_PATH}/skills/${SKILL_NAME}/" ".claude/skills/${SKILL_NAME}/"

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against the current code and only fix it if needed.

In @skills/agent-sort/SKILL.md around lines 137 - 149, The installation section
"Copy DAILY items" and "Copy LIBRARY items" uses abstract conventions (e.g.
Agents → .claude/skills/{name}/SKILL.md and All non-DAILY →
.claude/skills/skill-library/references/{prefix}-{name}.md) but lacks concrete
shell examples; add short, copy/pasteable command templates showing mkdir -p and
cp/cp -r usage for each case (referencing the headings "Copy DAILY items" and
"Copy LIBRARY items" and the example target paths .claude/skills/{name}/SKILL.md
and .claude/skills/skill-library/references/{prefix}-{name}.md) so readers can
directly run the commands to copy Agents, Skills, Commands, Contexts and library
items.

</details>

---

`39-59`: **Clarify that agent instructions use pseudo-code patterns.**

The agent instruction blocks (lines 40-58 and similar blocks for other agents) use pseudo-code notation like `Glob("**/*.ts")` within what appear to be bash code blocks. This could confuse users who might try to execute these literally.

Consider either:
1. Adding a note that these are instructions for AI agents, not executable shell commands
2. Providing actual implementation examples alongside the pseudo-code
3. Using a different formatting (e.g., plain text instead of code blocks) to distinguish from executable commands in Steps 1, 5, and 6

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against the current code and only fix it if needed.

In @skills/agent-sort/SKILL.md around lines 39 - 59, The agent instruction
blocks use pseudo-code like Glob("/*.ts", "/.tsx") and look like executable
shell commands, which can confuse readers; update the blocks (those containing
Glob(...) and the "Read the first 20 lines..." steps and Steps 1, 5, 6) to
clearly indicate they are AI/agent pseudocode by either (a) adding a one-line
note before each block saying "This is pseudocode for AI agents — not an
executable shell command", (b) switching the code-block formatting to plain text
or a labeled "PSEUDOCODE" block, or (c) include a small real example
implementation alongside the pseudocode (e.g., a shell/glob snippet) so readers
see the distinction; ensure references to Glob("**/.ts", "**/*.py", etc.)
remain unchanged except for the added clarifying text/formatting.

</details>

</blockquote></details>

</blockquote></details>

<details>
<summary>🤖 Prompt for all review comments with AI agents</summary>

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @skills/agent-sort/SKILL.md:

• Around line 151-152: Add a clear specification for the router SKILL.md by
  updating the "Create router" section: define the required frontmatter schema
  (e.g., title, id, description, version, author), specify the trigger table
  format as a Markdown table with columns like "item_id | keywords | description |
  path" and exact parsing rules, describe how to extract/generate keywords from
  library items (suggest tokenization, stopword removal, and manual overrides via
  a "keywords" field in each item), and include a complete, concrete example
  SKILL.md that demonstrates frontmatter plus a populated trigger table for
  multiple library items; reference the ".claude/skills/skill-library/SKILL.md"
  file and the "Create router" heading so reviewers can find and validate the
  added schema and example.
• Around line 211-217: Replace the unsafe one-liner that conditionally runs rm
  -rf on .claude/rules/python/ with a guarded sequence: first check the directory
  exists (".claude/rules/python/"), then run the find command but exclude
  "./.claude/" and "./node_modules/" and redirect errors to /dev/null to avoid
  find failures affecting the test, capture the file count into a variable (e.g.,
  PY_COUNT), and only call rm -rf if PY_COUNT equals 0; also echo a
  confirmation/log message before removal to make the action explicit. Ensure the
  logic references the same path ".claude/rules/python/" and that rm -rf is only
  executed after the directory existence and zero-count checks succeeded.
• Around line 1-233: The SKILL.md must be restructured to include the required
  top-level sections "When to Use", "How It Works", and "Examples": extract the
  trigger phrases from the frontmatter description into a concise "When to Use"
  list (include phrases like "sort ECC", "set up ECC", "install ECC for this
  project", etc.), convert Steps 1–6 into a narrative "How It Works" that explains
  locating ECC, launching 6 agents (Agents, Skills, Commands, Rules, Hooks,
  Extras), compiling results, installing files, and verification, and add an
  "Examples" section with at least one end-to-end example showing a sample
  command/flow and the expected outputs (summary counts and success checks)
  referencing the Step 5 verification commands so the example demonstrates their
  expected results; update any inline procedural fragments to follow prose
  sections rather than raw step headings.
• Around line 181-197: Replace fragile ls/globstar usage with robust checks: for
  the skills count, ensure the .claude/skills directory exists, list only
  immediate subdirectories and exclude the "skill-library" entry
  (.claude/skills//), and return 0 if none exist; for library references, ensure
  .claude/skills/skill-library/references exists and count files there; for rules,
  stop using the globstar pattern (.claude/rules/**/.md) and use a recursive file
  search limited to *.md under .claude/rules; for hooks keep the existing test for
  .claude/hooks/hooks.json but explicitly check the directory exists and handle
  missing files gracefully; for scripts ( .claude/scripts/hooks and
  .claude/scripts/lib ) ensure directories exist before counting and return zero
  if empty — overall replace glob-dependent commands with existence checks and
  recursive file searches so the checks are portable and safe.

---

Nitpick comments:
In @skills/agent-sort/SKILL.md:

• Around line 219-233: The hardcoded "always-DAILY" lists (the
  Agents/Skills/Commands/Contexts block containing entries like planner,
  architect, code-reviewer, coding-standards, tdd-workflow, learn, checkpoint,
  dev, review) must be validated against the ECC at runtime: update the code that
  consumes this SKILL.md list to query the ECC metadata for each named
  Agent/Skill/Command/Context, log a warning for any missing items, and fallback
  to deriving the DAILY set dynamically from ECC tags/metadata if many expected
  items are absent; ensure the validation and warning logic references the same
  identifiers ("Agents", "Skills", "Commands", "Contexts" groups and the
  individual names) so mismatches are detected rather than silently assumed.
• Around line 137-149: The installation section "Copy DAILY items" and "Copy
  LIBRARY items" uses abstract conventions (e.g. Agents →
  .claude/skills/{name}/SKILL.md and All non-DAILY →
  .claude/skills/skill-library/references/{prefix}-{name}.md) but lacks concrete
  shell examples; add short, copy/pasteable command templates showing mkdir -p and
  cp/cp -r usage for each case (referencing the headings "Copy DAILY items" and
  "Copy LIBRARY items" and the example target paths .claude/skills/{name}/SKILL.md
  and .claude/skills/skill-library/references/{prefix}-{name}.md) so readers can
  directly run the commands to copy Agents, Skills, Commands, Contexts and library
  items.
• Around line 39-59: The agent instruction blocks use pseudo-code like
  Glob("/*.ts", "/.tsx") and look like executable shell commands, which can
  confuse readers; update the blocks (those containing Glob(...) and the "Read the
  first 20 lines..." steps and Steps 1, 5, 6) to clearly indicate they are
  AI/agent pseudocode by either (a) adding a one-line note before each block
  saying "This is pseudocode for AI agents — not an executable shell command", (b)
  switching the code-block formatting to plain text or a labeled "PSEUDOCODE"
  block, or (c) include a small real example implementation alongside the
  pseudocode (e.g., a shell/glob snippet) so readers see the distinction; ensure
  references to Glob("**/.ts", "**/*.py", etc.) remain unchanged except for the
  added clarifying text/formatting.

</details>

<details>
<summary>🪄 Autofix (Beta)</summary>

Fix all unresolved CodeRabbit comments on this PR:

- [ ] <!-- {"checkboxId": "4b0d0e0a-96d7-4f10-b296-3a18ea78f0b9"} --> Push a commit to this branch (recommended)
- [ ] <!-- {"checkboxId": "ff5b1114-7d8c-49e6-8ac1-43f82af23a33"} --> Create a new PR with the fixes

</details>

---

<details>
<summary>ℹ️ Review info</summary>

<details>
<summary>⚙️ Run configuration</summary>

**Configuration used**: defaults

**Review profile**: CHILL

**Plan**: Pro

**Run ID**: `ef8727be-ca31-433b-9850-a781d65f8f52`

</details>

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 8b6140dedca32f081ba6964854bb70da31237f5e and 292fd73864913c394830b590f14aca77fe870422.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `skills/agent-sort/SKILL.md`

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->